Indie-Resource.com

Hey guys, I'm making a JS game where every time you click the button it increases by 1. Whats happening right now is the number goes up 1 but than resets back to 0 every time, can anyone help me out.

index.html:

script.js Here is a picture so you get a general idea.

The scope of the variable is wrong. Either you pass the current variable inside the function, or you declare an object where the variable is a field. I would suggest using the second method.

you dont need a semi colon when calling the function from a link.

Like i said before, the scope of that variable is wrong. All declared variables inside functions are local variables. You are trying to increment a variable outside of the function, instead, what you are doing is making a new variable every time you call that function, and you increment that one. So yeah, that one will always be 1.

What you can do is something like this:

var Game = {
timesClicked : 0,
increment : function(){
game.timesClicked++;
document.getElementById("number").innerHTML = timesClicked;
}
}

actually he declared it outside of the function therefore it is a global variable.

var timesClicked = 0;

Yeah, but within functions, you explicitly deal with local variables unless told otherwise.

var something = 10;

function someFunction(){
something = 30;
alert(something); // 30

}

alert(something); // 10

Also, on a side note, global variables like that are bad. Either create an annonymous functions, or wrap your code within (). This should hide the code from the global namespace in Javascript engines.

A closure could also be of use here, since it could hold the variable's value between function calls. They seem a bit advanced for a JS beginner at first, but I really like the explanation in the tutorial I linked.

ah sorry I confused myself on what you were referring to. Just pass the global through the function for a easy fix.